| Summary: | Fixes to match BaseAudioContext.idl to spec | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Clark Wang <clark_wang> | ||||||||||
| Component: | Web Audio | Assignee: | Clark Wang <clark_wang> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, jer.noble, kondapallykalyan, philipj, sergio, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 212611 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Clark Wang
2020-07-17 11:23:06 PDT
Created attachment 404592 [details]
Patch
Created attachment 404593 [details]
Patch
Comment on attachment 404593 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404593&action=review > Source/WebCore/Modules/webaudio/BaseAudioContext.cpp:-526 > - return PannerNode::create(*this, sampleRate()); So who is using this old factory / constructor now? If no one is, then why aren't you removing it in this patch? We don't want to keep dead code around, especially dead code that is not spec-compliant. (In reply to Chris Dumez from comment #3) > Comment on attachment 404593 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=404593&action=review > > > Source/WebCore/Modules/webaudio/BaseAudioContext.cpp:-526 > > - return PannerNode::create(*this, sampleRate()); > > So who is using this old factory / constructor now? If no one is, then why > aren't you removing it in this patch? We don't want to keep dead code > around, especially dead code that is not spec-compliant. I think WebKitAudioPannerNode is still using PannerNodeBase, but otherwise I can remove old PannerNode constructor. Created attachment 404720 [details]
Patch
Created attachment 404740 [details]
Patch
Committed r264620: <https://trac.webkit.org/changeset/264620> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404740 [details]. |