| Summary: | Make DocumentParser.ParserState an enum class | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Rob Buis <rbuis> | ||||
| Component: | New Bugs | Assignee: | Rob Buis <rbuis> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, darin, esprehn+autocc, ews-watchlist, kangil.han, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Safari Technology Preview | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Rob Buis
2020-07-16 11:27:08 PDT
Created attachment 404468 [details]
Patch
Comment on attachment 404468 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404468&action=review > Source/WebCore/dom/DocumentParser.h:70 > + bool isStopped() const { return m_state >= ParserState::Stopped; } Very sneaky that this one is different from the other three. I wonder if some of the callers who are checking isStopped() actually should be checking !isParsing() instead. Committed r264501: <https://trac.webkit.org/changeset/264501> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404468 [details]. |