Bug 214414

Summary:

Update WPT css directory

Product:

WebKit

Reporter:

Carlos Alberto Lopez Perez <clopez>

Component:

Tools / Tests

Assignee:

Carlos Alberto Lopez Perez <clopez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, tsavell, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

Bug Depends on:

Bug Blocks:

213927

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Description Carlos Alberto Lopez Perez 2020-07-16 10:05:34 PDT

After updating the bigger parts of WPT css directory in different bugs (check see also field) ...  let's update everything else.

This is an update for the directories:

css-align
css-animations
css-backgrounds
css-box
css-cascade
css-color-adjust
css-display
css-fonts
css-images
css-inline
css-lists
css-logical
css-masking
css-multicol
css-overflow
css-overscroll-behavior
css-position
css-properties-values-api
css-pseudo
css-scoping
css-shadow-parts
css-shapes
css-sizing
css-syntax
css-text
css-text-decor
css-transitions
css-values
cssom
cssom-view
geometry
mediaqueries
reference
selectors

Comment 1 Carlos Alberto Lopez Perez 2020-07-16 10:12:50 PDT

Created attachment 404460 [details]
Patch

Test EWS. ignore

Comment 2 Carlos Alberto Lopez Perez 2020-07-16 17:20:12 PDT

Created attachment 404500 [details]
Patch

Test EWS. ignore

Comment 3 Carlos Alberto Lopez Perez 2020-07-16 17:29:09 PDT

Created attachment 404502 [details]
Patch

Test EWS. ignore

Comment 4 Carlos Alberto Lopez Perez 2020-07-17 06:39:20 PDT

Created attachment 404556 [details]
Patch

Hopefully EWS will be green

Comment 5 Carlos Alberto Lopez Perez 2020-07-17 08:44:28 PDT

Created attachment 404565 [details]
Patch

Comment 6 Chris Dumez 2020-07-17 09:48:49 PDT

Looks like imported/w3c/web-platform-tests/css/css-display/display-first-line-002.html	 is failing.

Comment 7 Carlos Alberto Lopez Perez 2020-07-17 10:11:08 PDT

Created attachment 404571 [details]
Patch

Comment 8 Carlos Alberto Lopez Perez 2020-07-17 10:12:52 PDT

(In reply to Chris Dumez from comment #6)
> Looks like
> imported/w3c/web-platform-tests/css/css-display/display-first-line-002.html	
> is failing.

Right. I have updated the patch. Diff from previous: http://sprunge.us/GiudIS

I had already marked it, but only for GTK and WPE. Now moved to the general expectation.

Comment 9 EWS 2020-07-17 10:52:35 PDT

Tools/Scripts/svn-apply failed to apply attachment 404571 [details] to trunk.
Please resolve the conflicts and upload a new patch.

Comment 10 Carlos Alberto Lopez Perez 2020-07-17 10:57:09 PDT

Created attachment 404573 [details]
Patch

Patch for landing

Comment 11 EWS 2020-07-17 11:27:32 PDT

Committed r264522: <https://trac.webkit.org/changeset/264522>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404573 [details].

Comment 12 Radar WebKit Bug Importer 2020-07-17 11:28:21 PDT

<rdar://problem/65735498>

Comment 13 Truitt Savell 2020-07-17 16:17:22 PDT

Reverted r264549 for reason:

Expectation made in the wrong folder

Committed r264550: <https://trac.webkit.org/changeset/264550>

Comment 14 Truitt Savell 2020-07-17 16:20:07 PDT

I made a change to the wrong file location in https://trac.webkit.org/changeset/264549/webkit and just corrected it. 

when the rebase of compositing/repaint/iframes/compositing-iframe-scroll-repaint-expected.txt was done it was not actually needed for production bots given the history and diffs:
https://results.webkit.org/?suite=layout-tests&test=compositing%2Frepaint%2Fiframes%2Fcompositing-iframe-scroll-repaint.html

I am correcting this now

Comment 15 Truitt Savell 2020-07-17 16:25:47 PDT

Corrected expectation file in https://trac.webkit.org/changeset/264551/webkit

Comment 16 Truitt Savell 2020-07-17 16:42:31 PDT

The rebasline of imported/w3c/web-platform-tests/css/css-sizing/percentage-height-in-flexbox.html doesn't look like it was necessary for trunk bots. can you confirm? 

tracking in https://bugs.webkit.org/show_bug.cgi?id=214510