Bug 214410

Summary: Integrate libwebm into the libwebrtc project.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, annulen, eric.carlson, ews-watchlist, glenn, gyuyoung.kim, jbedard, peng.liu6, philipj, ryuan.choi, sergio, webkit-bug-importer, youennf, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=214450
https://bugs.webkit.org/show_bug.cgi?id=214478
Bug Depends on: 214477    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Jer Noble 2020-07-16 09:29:44 PDT
Integrate libwebm into the libwebrtc project.
Comment 1 Radar WebKit Bug Importer 2020-07-16 10:02:39 PDT
<rdar://problem/65672748>
Comment 2 Jer Noble 2020-07-16 10:02:42 PDT
Created attachment 404458 [details]
Patch
Comment 3 Jer Noble 2020-07-16 11:00:13 PDT
Created attachment 404465 [details]
Patch
Comment 4 Jer Noble 2020-07-16 13:28:27 PDT
Created attachment 404479 [details]
Patch
Comment 5 Eric Carlson 2020-07-16 15:39:36 PDT
Comment on attachment 404479 [details]
Patch

rs=me once the bots are happy
Comment 6 EWS 2020-07-16 18:10:20 PDT
Committed r264492: <https://trac.webkit.org/changeset/264492>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404479 [details].
Comment 7 Yusuke Suzuki 2020-07-17 08:28:44 PDT
Re-opened since this is blocked by bug 214477
Comment 8 Jonathan Bedard 2020-07-17 08:30:26 PDT
Broke the iOS 13 Debug build: https://build.webkit.org/builders/Apple%20iOS%2013%20Simulator%20Debug%20(Build)?numbuilds=50

Note that r264491 changed a script only used to configure bots, so r264492 can be confidently blamed for the build failure.
Comment 9 Jer Noble 2020-07-20 09:34:47 PDT
(In reply to Jonathan Bedard from comment #8)
> Broke the iOS 13 Debug build:
> https://build.webkit.org/builders/
> Apple%20iOS%2013%20Simulator%20Debug%20(Build)?numbuilds=50
> 
> Note that r264491 changed a script only used to configure bots, so r264492
> can be confidently blamed for the build failure.

This build failure was fixed by r264517 <https://trac.webkit.org/changeset/264517/webkit> without a roll-out needed. Re-closing.