Bug 214397

Summary: run-minibrowser --debug runs the release build on macOS
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Tools / TestsAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, glenn, jbedard, pnormand, simon.fraser, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=214072
Attachments:
Description Flags
Patch none

Description Simon Fraser (smfr) 2020-07-15 21:57:33 PDT
run-minibrowser --debug runs release.

Also:

OpenSource % ./Tools/Scripts/run-minibrowser --help
Usage: old-run-minibrowser [options] [args ...]
  --help                            Show this help message
  --no-saved-state                  Launch the application without state restoration

Options specific to macOS:
  -g|--guard-malloc                 Enable Guard Malloc
  --lang=LANGUAGE                   Use a specific language instead of system language.
                                    This accepts a language name (German) or a language code (de, ar, pt_BR, etc).
  --locale=LOCALE                   Use a specific locale instead of the system region.

Options specific to iOS:
  --iphone-simulator                Run the app in an iPhone Simulator
  --ipad-simulator                  Run the app in an iPad Simulator

ScriptError raised: Failed to run "['Tools/Scripts/old-run-minibrowser', u'--help']" exit_code: 1 cwd: /Volumes/Data/Development/system/webkit/OpenSource
Traceback (most recent call last):
  File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/minibrowser/run_webkit_app.py", line 66, in main
    return port.run_minibrowser(browser_args)
  File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/port/base.py", line 1373, in run_minibrowser
    return self._executive.run_command([miniBrowser] + args, stdout=None, cwd=self.webkit_base(), return_stderr=False, decode_output=False)
  File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/common/system/executive.py", line 435, in run_command
    (error_handler or self.default_error_handler)(script_error)
  File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/common/system/abstractexecutive.py", line 97, in default_error_handler
    raise error
ScriptError: Failed to run "['Tools/Scripts/old-run-minibrowser', u'--help']" exit_code: 1 cwd: /Volumes/Data/Development/system/webkit/OpenSource
Comment 1 Philippe Normand 2020-07-16 01:45:43 PDT
Created attachment 404430 [details]
Patch
Comment 2 EWS 2020-07-16 02:24:02 PDT
Committed r264451: <https://trac.webkit.org/changeset/264451>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404430 [details].
Comment 3 Radar WebKit Bug Importer 2020-07-16 02:25:17 PDT
<rdar://problem/65654292>