Bug 214390

Summary: MiniBrowser toolbar is ugly with default macOS Big Sur style
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: sam, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
thorton: review+
Before
none
After (in dark mode) none

Description Dean Jackson 2020-07-15 17:59:08 PDT 
MiniBrowser toolbar is ugly with default macOS Big Sur styl
Comment 1 Radar WebKit Bug Importer 2020-07-15 17:59:40 PDT 
<rdar://problem/65637420>
Comment 2 Dean Jackson 2020-07-15 18:03:12 PDT 
Created attachment 404409 [details]
Patch
Comment 3 Dean Jackson 2020-07-15 18:06:25 PDT 
Created attachment 404410 [details]
Before
Comment 4 Dean Jackson 2020-07-15 18:07:34 PDT 
Created attachment 404411 [details]
After (in dark mode)
Comment 5 Tim Horton 2020-07-15 18:15:13 PDT 
Comment on attachment 404409 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404409&action=review

> Tools/MiniBrowser/mac/BrowserWindowController.m:46
> +#if TARGET_OS_OSX && __MAC_OS_X_VERSION_MIN_REQUIRED >= 110000

Why the TARGET_ check?

> Tools/MiniBrowser/mac/BrowserWindowController.m:51
> +    reloadButton.image = [NSImage imageWithSystemSymbolName:@"arrow.clockwise" accessibilityDescription:@"Reload"];

I believe it is possible to specify symbols in IB? But I could be wrong.
Comment 6 Sam Weinig 2020-07-15 18:31:35 PDT 
Seems like @available should be used instead for best practices here.
Comment 7 Dean Jackson 2020-07-15 18:39:47 PDT 
Committed r264441: <https://trac.webkit.org/changeset/264441>