| Summary: | Added Fixes for AudioScheduledSourceNode | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Clark Wang <clark_wang> | ||||||||||||
| Component: | Web Audio | Assignee: | Clark Wang <clark_wang> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | annulen, cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, kondapallykalyan, philipj, ryuan.choi, sergio, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | |||||||||||||||
| Bug Blocks: | 212611 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Clark Wang
2020-07-15 15:32:16 PDT
Created attachment 404401 [details]
Patch
Created attachment 404438 [details]
Patch
Comment on attachment 404438 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404438&action=review > Source/WebCore/ChangeLog:9 > + Added in ConstantSourceOptions files. Removed unrestricted keyword from attributes in Please do not put unrelated changes in a single patch. Ok, let me split up these changes into separate patches. Thanks! Created attachment 404450 [details]
Patch
Comment on attachment 404450 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404450&action=review > Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl:29 > ActiveDOMObject, You should be able to drop this now. > Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl:30 > +] interface AudioBufferSourceNode : AudioScheduledSourceNode { Well, then you'd want to drop start() / stop() / onended from this interface.. > Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp:139 > +ExceptionOr<void> AudioScheduledSourceNode::startLater(Optional<double> optionalWhen) That's wrong. There is already a default value of 0 in the IDL so the generated bindings will always give you a double. > Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp:159 > +ExceptionOr<void> AudioScheduledSourceNode::stopLater(Optional<double> optionalWhen) Ditto. > Source/WebCore/Modules/webaudio/OscillatorNode.idl:37 > ActiveDOMObject, You should be able to drop this now. > Source/WebCore/Modules/webaudio/OscillatorNode.idl:38 > +] interface OscillatorNode : AudioScheduledSourceNode { Well, then you'd want to drop start() / stop() / onended from this interface.. Comment on attachment 404450 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404450&action=review > Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl:29 > ActiveDOMObject, You should be able to drop this now. > Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl:30 > +] interface AudioBufferSourceNode : AudioScheduledSourceNode { Well, then you'd want to drop start() / stop() / onended from this interface.. > Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp:139 > +ExceptionOr<void> AudioScheduledSourceNode::startLater(Optional<double> optionalWhen) That's wrong. There is already a default value of 0 in the IDL so the generated bindings will always give you a double. > Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp:159 > +ExceptionOr<void> AudioScheduledSourceNode::stopLater(Optional<double> optionalWhen) Ditto. > Source/WebCore/Modules/webaudio/OscillatorNode.idl:37 > ActiveDOMObject, You should be able to drop this now. > Source/WebCore/Modules/webaudio/OscillatorNode.idl:38 > +] interface OscillatorNode : AudioScheduledSourceNode { Well, then you'd want to drop start() / stop() / onended from this interface.. Created attachment 404486 [details]
Patch
Created attachment 404576 [details]
Patch
Committed r264538: <https://trac.webkit.org/changeset/264538> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404576 [details]. |