Bug 214372

Summary: [ews] clicking submit for EWS analysis button for patches on closed bug should display error
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, beidson, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=210803
Attachments:
Description Flags
Patch none

Description Aakash Jain 2020-07-15 13:22:09 PDT 
Clicking 'submit for EWS analysis' button for patches on closed bug should display error, and such patches shouldn't be sent to EWS (buildbot). This is because the first thing our Buildbot builders do is to validate-patch, which will skip the patch if the corresponding bug is closed. Therefore sending the patch to Buildbot is useless, and might be confusing for users.

It's better to display an error that the patch is not being sent to EWS since the corresponding bug is already closed.
Comment 1 Aakash Jain 2020-07-15 13:27:24 PDT 
Created attachment 404384 [details]
Patch
Comment 2 Aakash Jain 2020-07-15 13:28:30 PDT 
Tested in https://ews.webkit-uat.org/status-bubble/404379 (feel free to click the button to check the new behavior)
Comment 3 EWS 2020-07-15 14:18:06 PDT 
Committed r264421: <https://trac.webkit.org/changeset/264421>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404384 [details].
Comment 4 Radar WebKit Bug Importer 2020-07-15 14:19:18 PDT 
<rdar://problem/65626564>
Comment 5 Aakash Jain 2020-07-15 14:42:45 PDT 
> Committed r264421: <https://trac.webkit.org/changeset/264421>
Deployed it on the server.