| Summary: | Improve handling of invalid ChangeLog by webkit-patch | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aakash_jain, ap, ews-watchlist, glenn, jbedard, simon.fraser, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | Safari Technology Preview | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=213609 | ||||||||
| Attachments: |
|
||||||||
Created attachment 404360 [details]
My cached changes
The WebKit/Changelog file has a space at the start of the date line. Created attachment 404441 [details]
Patch
Committed r264455: <https://trac.webkit.org/changeset/264455> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404441 [details]. |
OpenSource % wkpatch upload -g HEAD.... --no-review --no-obsolete Total errors found: 0 in 13 files Traceback (most recent call last): File "Tools/Scripts/webkit-patch", line 80, in <module> main() File "Tools/Scripts/webkit-patch", line 75, in main WebKitPatch(os.path.abspath(__file__)).main() File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main result = command.check_arguments_and_execute(options, args, self) File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 55, in execute self._sequence.run_and_handle_errors(tool, options, state) File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors self._run(tool, options, state) File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run step(tool, options).run(state) File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/tool/steps/preparechangelog.py", line 106, in run self._ensure_bug_url(state) File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/tool/steps/preparechangelog.py", line 58, in _ensure_bug_url if not changelog.latest_entry().bug_id(): AttributeError: 'NoneType' object has no attribute 'bug_id' Will attach my local diff.