Bug 214339

Summary: [CMake][WebDriver] Generating WebDriverAtoms.cpp is rarely failing as "ImportError: No module named jsmin"
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: WebDriverAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bburg, don.olmstead, ews-watchlist, gyuyoung.kim, keith_miller, mark.lam, msaboff, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Fujii Hironori
Reported 2020-07-14 20:26:17 PDT
[CMake][WebDriver] Generating DerivedSources/WebDriver/WebDriverAtoms.cpp is rarely failing as "ImportError: No module named jsmin" Building WinCairo is rarely failing as the following error. > [1106/5278] Generating ../../DerivedSources/WebDriver/WebDriverAtoms.h, ../../DerivedSources/WebDriver/WebDriverAtoms.cpp > FAILED: DerivedSources/WebDriver/WebDriverAtoms.h DerivedSources/WebDriver/WebDriverAtoms.cpp > cmd.exe /C "cd /D C:\jenkins_slave\WinCairo-master\WebKitBuild\Release\Source\WebDriver && C:\Python27\python.exe C:/jenkins_slave/WinCairo-master/WebKitBuild/Release/JavaScriptCore/Scripts/make-js-file-arrays.py -n WebDriver C:/jenkins_slave/WinCairo-master/WebKitBuild/Release/DerivedSources/WebDriver/WebDriverAtoms.h C:/jenkins_slave/WinCairo-master/WebKitBuild/Release/DerivedSources/WebDriver/WebDriverAtoms.cpp C:/jenkins_slave/WinCairo-master/Source/WebKit/UIProcess/Automation/atoms/ElementAttribute.js C:/jenkins_slave/WinCairo-master/Source/WebKit/UIProcess/Automation/atoms/ElementDisplayed.js C:/jenkins_slave/WinCairo-master/Source/WebKit/UIProcess/Automation/atoms/ElementEnabled.js C:/jenkins_slave/WinCairo-master/Source/WebKit/UIProcess/Automation/atoms/EnterFullscreen.js C:/jenkins_slave/WinCairo-master/Source/WebKit/UIProcess/Automation/atoms/FindNodes.js C:/jenkins_slave/WinCairo-master/Source/WebKit/UIProcess/Automation/atoms/FormElementClear.js C:/jenkins_slave/WinCairo-master/Source/WebKit/UIProcess/Automation/atoms/FormSubmit.js" > Traceback (most recent call last): > > File "C:/jenkins_slave/WinCairo-master/WebKitBuild/Release/JavaScriptCore/Scripts/make-js-file-arrays.py", line 29, in <module> > > from jsmin import jsmin > > ImportError: No module named jsmin
Attachments
Patch (3.01 KB, patch)
2020-07-14 20:48 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2020-07-14 20:34:16 PDT
This can be reproduced by invoking "ninja DerivedSources\WebDriver\WebDriverAtoms.cpp". PS C:\home\webkit\gc> cd .\WebKitBuild\Debug\ PS C:\home\webkit\gc\WebKitBuild\Debug> ninja DerivedSources\WebDriver\WebDriverAtoms.cpp [507/508] Linking CXX shared library bin64\WTF.dll Creating library lib64\WTF.lib and object lib64\WTF.exp Creating library lib64\WTF.lib and object lib64\WTF.exp [508/508] Generating ../../DerivedSources/WebDriver/WebDriverAtoms.h, ../../DerivedSources/WebDriver/WebDriverAtoms.cpp FAILED: DerivedSources/WebDriver/WebDriverAtoms.h DerivedSources/WebDriver/WebDriverAtoms.cpp cmd.exe /C "cd /D C:\home\webkit\gc\WebKitBuild\Debug\Source\WebDriver && C:\Python27\python.exe C:/home/webkit/gc/WebKitBuild/Debug/JavaScriptCore/Scripts/make-js-file-arrays.py -n WebDriver C:/home/webkit/gc/WebKitBuild/Debug/DerivedSources/WebDriver/WebDriverAtoms.h C:/home/webkit/gc/WebKitBuild/Debug/DerivedSources/WebDriver/WebDriverAtoms.cpp C:/home/webkit/gc/Source/WebKit/UIProcess/Automation/atoms/ElementAttribute.js C:/home/webkit/gc/Source/WebKit/UIProcess/Automation/atoms/ElementDisplayed.js C:/home/webkit/gc/Source/WebKit/UIProcess/Automation/atoms/ElementEnabled.js C:/home/webkit/gc/Source/WebKit/UIProcess/Automation/atoms/EnterFullscreen.js C:/home/webkit/gc/Source/WebKit/UIProcess/Automation/atoms/FindNodes.js C:/home/webkit/gc/Source/WebKit/UIProcess/Automation/atoms/FormElementClear.js C:/home/webkit/gc/Source/WebKit/UIProcess/Automation/atoms/FormSubmit.js" Traceback (most recent call last): File "C:/home/webkit/gc/WebKitBuild/Debug/JavaScriptCore/Scripts/make-js-file-arrays.py", line 29, in <module> from jsmin import jsmin ImportError: No module named jsmin ninja: build stopped: subcommand failed. PS C:\home\webkit\gc\WebKitBuild\Debug>
Fujii Hironori
Comment 2 2020-07-14 20:48:44 PDT
Created attachment 404317 [details] Patch
Fujii Hironori
Comment 3 2020-07-15 13:18:15 PDT
Comment on attachment 404317 [details] Patch Clearing flags on attachment: 404317 Committed r264417: <https://trac.webkit.org/changeset/264417>
Fujii Hironori
Comment 4 2020-07-15 13:18:19 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2020-07-15 13:19:17 PDT
<rdar://problem/65623334>
Note You need to log in before you can comment on or make changes to this bug.