Bug 214332

Summary:

We must hold the CodeBlock lock when calling StructureStubInfo::reset

Product:

WebKit

Reporter:

Saam Barati <saam>

Component:

JavaScriptCore

Assignee:

Saam Barati <saam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, fpizlo, ggaren, gskachkov, guijemont, jsc32, keith_miller, mark.lam, msaboff, rmorisset, ross.kirsling, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none

Description Saam Barati 2020-07-14 16:44:51 PDT

...

Comment 1 Saam Barati 2020-07-14 16:45:32 PDT

<rdar://problem/64940787>

Comment 2 Saam Barati 2020-07-14 16:54:18 PDT

Created attachment 404307 [details]
patch

Comment 3 Yusuke Suzuki 2020-07-14 16:56:35 PDT

Comment on attachment 404307 [details]
patch

r=me

Comment 4 Saam Barati 2020-07-14 16:57:28 PDT

Comment on attachment 404307 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404307&action=review

> Source/JavaScriptCore/jit/Repatch.cpp:148
> +        {
> +            GCSafeConcurrentJSLocker locker(codeBlock->m_lock, vm.heap);
> +            stubInfo.reset(locker, codeBlock);
> +        }

this is the bug fix

Comment 5 EWS 2020-07-14 22:54:50 PDT

Committed r264388: <https://trac.webkit.org/changeset/264388>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404307 [details].