Bug 214301

Summary: WPT test css/css-grid/grid-definition/grid-auto-fit-columns-001.html broken after r264335
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: CSSAssignee: Carlos Alberto Lopez Perez <clopez>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, ews-watchlist, jfernandez, rego, svillar, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=214284
Attachments:
Description Flags
Patch
none
Patch none

Carlos Alberto Lopez Perez
Reported 2020-07-14 05:42:32 PDT
r264335 updated the imported css-grid WPT tests. The update contains a change (base href) for the test imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001.html that breaks it.
Attachments
Patch (34.25 KB, patch)
2020-07-14 05:53 PDT, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
Patch (35.14 KB, patch)
2020-07-14 06:01 PDT, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1 2020-07-14 05:53:06 PDT
Created attachment 404226 [details] Patch
EWS Watchlist
Comment 2 2020-07-14 05:54:22 PDT
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Carlos Alberto Lopez Perez
Comment 3 2020-07-14 05:56:30 PDT
Ok.. I just noticed this has been fixed on WPT 4b5101fabe653a57921f6e7add9ff768027206fa
Carlos Alberto Lopez Perez
Comment 4 2020-07-14 06:01:45 PDT
Created attachment 404227 [details] Patch Import commit 4b5101fabe from WPT and update expectations
Manuel Rego Casasnovas
Comment 5 2020-07-14 06:03:50 PDT
Comment on attachment 404227 [details] Patch r=me
EWS
Comment 6 2020-07-14 08:32:55 PDT
Committed r264339: <https://trac.webkit.org/changeset/264339> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404227 [details].
Radar WebKit Bug Importer
Comment 7 2020-07-14 08:33:15 PDT
<rdar://problem/65544302>
Note You need to log in before you can comment on or make changes to this bug.