Bug 214253

Summary: Building RenderThemeMac.mm with the macOS Big Sur public SDK fails
Product: WebKit Reporter: Rob Buis <rbuis>
Component: New BugsAssignee: Rob Buis <rbuis>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: benjamin, cdumez, changseok, cmarcelo, esprehn+autocc, ews-watchlist, glenn, jbedard, kondapallykalyan, pdr
Priority: P2    
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=214396
Bug Depends on:    
Bug Blocks: 214043    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Rob Buis 2020-07-13 05:10:44 PDT
Build errors:
./rendering/RenderThemeMac.mm:2732:27: error: class method '+_imageWithSystemSymbolName:' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]
    auto image = [NSImage _imageWithSystemSymbolName:@"arrow.down.circle"];
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~
./rendering/RenderThemeMac.mm:2732:5: error: 'auto' deduced as 'id' in declaration of 'image' [-Werror,-Wauto-var-id]
    auto image = [NSImage _imageWithSystemSymbolName:@"arrow.down.circle"];
    ^~~~~~~~~~
./rendering/RenderThemeMac.mm:2738:9: error: use of undeclared identifier 'NSImageHintSymbolFont'
        NSImageHintSymbolFont : [NSFont systemFontOfSize:32],
        ^
./rendering/RenderThemeMac.mm:2739:9: error: use of undeclared identifier 'NSImageHintSymbolScale'
        NSImageHintSymbolScale : @(NSImageSymbolScaleMedium)
        ^
./rendering/RenderThemeMac.mm:2739:36: error: use of undeclared identifier 'NSImageSymbolScaleMedium'
        NSImageHintSymbolScale : @(NSImageSymbolScaleMedium)
                                   ^
5 errors generated.
Comment 1 Rob Buis 2020-07-13 05:47:21 PDT
Created attachment 404141 [details]
Patch
Comment 2 Rob Buis 2020-07-13 05:51:51 PDT
Created attachment 404142 [details]
Patch
Comment 3 Rob Buis 2020-07-13 08:30:57 PDT
Created attachment 404150 [details]
Patch
Comment 4 Rob Buis 2020-07-13 09:03:33 PDT
Created attachment 404151 [details]
Patch
Comment 5 Jonathan Bedard 2020-07-15 22:26:25 PDT
Linked this up to https://bugs.webkit.org/show_bug.cgi?id=214396, which should be enough to get WebKit to build for Big Sur with the Seed 1 SDK.
Comment 6 Rob Buis 2020-07-16 00:26:11 PDT
Looks like https://bugs.webkit.org/show_bug.cgi?id=214396 will fix this, closing this one, thanks!

*** This bug has been marked as a duplicate of bug 214396 ***