Bug 214251

Summary: [GTK] Prepare unit tests for GTK4
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, berto, bugs-noreply, ews-watchlist, gustavo, webkit-bug-importer
Priority: P2 Keywords: Gtk, InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 210100, 214344    
Attachments:
Description Flags
Patch aperez: review+

Carlos Garcia Campos
Reported 2020-07-13 02:49:27 PDT
In GTK there isn't GTK_WINDOW_POPUP and we can't create GdkEvents, so we need to use toplevel windows everywhere and use the new internal api to synthesize events.
Attachments
Patch (54.74 KB, patch)
2020-07-13 03:24 PDT, Carlos Garcia Campos 		aperez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2020-07-13 03:24:20 PDT
Created attachment 404140 [details] Patch
EWS Watchlist
Comment 2 2020-07-13 03:25:08 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Adrian Perez
Comment 3 2020-07-20 09:06:53 PDT
Comment on attachment 404140 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404140&action=review > Tools/TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:45 > + g_main_context_iteration(nullptr, TRUE); Wow, it's amazing that it's 2020 and we were still using the gtk_* main loop functions 😅️
Carlos Garcia Campos
Comment 4 2020-07-21 01:08:27 PDT
Committed r264647: <https://trac.webkit.org/changeset/264647>
Radar WebKit Bug Importer
Comment 5 2020-07-21 01:09:13 PDT
<rdar://problem/65871310>
Note You need to log in before you can comment on or make changes to this bug.