Bug 214244

Summary: [GTK][WPE] WTR and API-tests timing out after r264283
Product: WebKit Reporter: Lauro Moura <lmoura>
Component: WebKitGTKAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, darin, eric.carlson, ews-watchlist, glenn, Hironori.Fujii, jer.noble, philipj, pvollan, sergio, zan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=214233
Attachments:
Description Flags
WIP patch
none
Patch
none
Patch for landing none

Description Lauro Moura 2020-07-12 19:46:12 PDT
All WTR tests exiting early due to all tests timing out.

For example, fast/css/tab-size.html gets stuck in the platformRunUntil waiting for the response from WKPageLoadURLWithShouldOpenExternalURLsPolicy in the TestInvocation.cpp.

Sample WTR output: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/14627/steps/layout-test/logs/stdio

Some API tests also exiting, many from the C API tests where pages are loaded.

For example, /TestWebKit WebKit.PageLoadTwiceAndReload gets stuck with none of the two loaderClient callbacks (didFinishNavigation and didFailProvisionalNavigation) being called.

Sample API tests output: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/14627/steps/API%20tests/logs/stdio
Comment 1 Lauro Moura 2020-07-12 20:49:31 PDT
More info:

Minibrowser seems to be working file. Checking the Loading channel from systemd:

WTR (fails):

jul 13 00:06:55 lauro-desktop WebKitWebProcess[88070]: 0x7f6a926fa3b0 - [pageID=8, frameID=3] PolicyChecker::checkNavigationPolicy: continuing because this is an initial empty document
jul 13 00:06:55 lauro-desktop WebKitWebProcess[88070]: 0x7f6a926fa3b0 - [pageID=8, frameID=3] PolicyChecker::checkNavigationPolicy: ignoring because policyAction from dispatchDecidePolicyForNavigationAction is Ignore

From Minibrowser (works):

jul 13 00:09:24 lauro-desktop WebKitWebProcess[89059]: 0x7f65e6cfa400 - [pageID=6, frameID=3] PolicyChecker::checkNavigationPolicy: continuing because this policyAction from dispatchDecidePolicyForNavigationAction is Use
Comment 2 Zan Dobersek 2020-07-13 00:09:23 PDT
Created attachment 404129 [details]
WIP patch
Comment 3 Zan Dobersek 2020-07-13 00:59:43 PDT
Created attachment 404130 [details]
Patch
Comment 4 Zan Dobersek 2020-07-13 02:29:44 PDT
Created attachment 404136 [details]
Patch for landing
Comment 5 Zan Dobersek 2020-07-13 02:31:28 PDT
*** Bug 214248 has been marked as a duplicate of this bug. ***
Comment 6 Zan Dobersek 2020-07-13 02:32:09 PDT
Comment on attachment 404136 [details]
Patch for landing

Clearing flags on attachment: 404136

Committed r264297: <https://trac.webkit.org/changeset/264297>
Comment 7 Zan Dobersek 2020-07-13 02:32:14 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Darin Adler 2020-07-13 09:13:14 PDT
Thanks, this looks fine to me.