| Summary: | Some further streamlining of Gradient handling code | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||
| Component: | Layout and Rendering | Assignee: | Darin Adler <darin> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, bfulgham, cdumez, changseok, cmarcelo, dino, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, kondapallykalyan, pdr, sabouhallawa, sam, schenney, sergio, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Darin Adler
2020-07-12 13:33:00 PDT
Created attachment 404115 [details]
Patch
Created attachment 404116 [details]
Patch
Parts of this were driven by Sam’s comments on my last patch. Comment on attachment 404116 [details]
Patch
Passing all the EWS tests.
Comment on attachment 404116 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404116&action=review > Source/WebCore/rendering/svg/RenderSVGResourceGradient.cpp:150 > + gradient->setGradientSpaceTransform(userspaceTransform); > + > + return { WTFMove(gradient), userspaceTransform }; What is the purpose of storing the userspaceTransform both on the Gradient and in the GradientData? Comment on attachment 404116 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404116&action=review >> Source/WebCore/rendering/svg/RenderSVGResourceGradient.cpp:150 >> + return { WTFMove(gradient), userspaceTransform }; > > What is the purpose of storing the userspaceTransform both on the Gradient and in the GradientData? I asked myself the same question. > Source/WebCore/rendering/svg/RenderSVGResourceGradient.cpp:174 > + gradientData.gradient->setGradientSpaceTransform(transformOnNonScalingStroke(&renderer, gradientData.userspaceTransform)); Here is where it’s used. The only place it’s used. Maybe it could be removed. I don’t understand it well enough to be sure at this point. Committed r264290: <https://trac.webkit.org/changeset/264290> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404116 [details]. |