Bug 214228

Summary: REGRESSION(r264270): Broke the build
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 214224    
Attachments:
Description Flags
REVERT of r264270 none

Description Yusuke Suzuki 2020-07-11 21:37:49 PDT 
https://trac.webkit.org/changeset/264270 broke the build:
Broke the build

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 Yusuke Suzuki 2020-07-11 21:37:55 PDT 
Created attachment 404086 [details]
REVERT of r264270

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the revert will be successful.  This process takes approximately 15 minutes.

If you would like to land the revert faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Alexey Proskuryakov 2020-07-11 21:38:31 PDT 
Comment on attachment 404086 [details]
REVERT of r264270

Failure details in Slack.
Comment 3 EWS 2020-07-11 21:39:35 PDT 
Committed r264274: <https://trac.webkit.org/changeset/264274>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404086 [details].
Comment 4 Radar WebKit Bug Importer 2020-07-11 21:40:14 PDT 
<rdar://problem/65418841>
Comment 5 Yusuke Suzuki 2020-07-12 02:47:44 PDT 
This broke OSS builds.
https://build.webkit.org/builders/Apple%20Mojave%20Debug%20%28Build%29/builds/17889
Comment 6 Yusuke Suzuki 2020-07-12 02:47:54 PDT 
(In reply to Yusuke Suzuki from comment #5)
> This broke OSS builds.
> https://build.webkit.org/builders/Apple%20Mojave%20Debug%20%28Build%29/
> builds/17889

Fixed in https://trac.webkit.org/changeset/264277/webkit