| Summary: | [iOS] Prevent SPI clients from making the minimum layout height or width negative | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||
| Component: | WebKit API | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Wenson Hsieh
2020-07-10 14:28:46 PDT
Created attachment 404003 [details]
Patch
Comment on attachment 404003 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404003&action=review > Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:2947 > + NSLog(@"%s: Error: attempting to override layout parameters with negative width or height: %@", __PRETTY_FUNCTION__, NSStringFromCGSize(minimumLayoutSize)); os_log_error, maybe? or even os_log_fault? It is v. v. bad if we get here. (In reply to Tim Horton from comment #2) > Comment on attachment 404003 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=404003&action=review > > > Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:2947 > > + NSLog(@"%s: Error: attempting to override layout parameters with negative width or height: %@", __PRETTY_FUNCTION__, NSStringFromCGSize(minimumLayoutSize)); > > os_log_error, maybe? or even os_log_fault? It is v. v. bad if we get here. os_log_fault it is! Created attachment 404004 [details]
For EWS
Committed r264248: <https://trac.webkit.org/changeset/264248> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404004 [details]. |