| Summary: | Add EWS queues for tvOS and watchOS builders | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ap, dean_johnson, jbedard, jlewis3, ryanhaddad, slewis, thorton, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=213402 https://bugs.webkit.org/show_bug.cgi?id=214279 https://bugs.webkit.org/show_bug.cgi?id=214214 |
||||||
| Attachments: |
|
||||||
|
Description
Aakash Jain
2020-07-09 10:25:47 PDT
Created attachment 403886 [details]
Patch
Comment on attachment 403886 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403886&action=review > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:46 > + ALL_QUEUES = ['style', 'ios', 'ios-sim', 'mac', 'mac-debug', 'tv', 'tv-sim', 'watch', 'watch-sim', 'gtk', 'wpe', 'wincairo', 'win', I think we should use 'tvos' and 'watchos' instead of 'tv' and 'watch'. (In reply to Ryan Haddad from comment #2) > > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:46 > > + ALL_QUEUES = ['style', 'ios', 'ios-sim', 'mac', 'mac-debug', 'tv', 'tv-sim', 'watch', 'watch-sim', 'gtk', 'wpe', 'wincairo', 'win', > > I think we should use 'tvos' and 'watchos' instead of 'tv' and 'watch'. These names appear in status-bubbles on Bugzilla, so I was trying to keep them small (similar to 'mac' instead of 'macos'). (In reply to Aakash Jain from comment #3) > (In reply to Ryan Haddad from comment #2) > > > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:46 > > > + ALL_QUEUES = ['style', 'ios', 'ios-sim', 'mac', 'mac-debug', 'tv', 'tv-sim', 'watch', 'watch-sim', 'gtk', 'wpe', 'wincairo', 'win', > > > > I think we should use 'tvos' and 'watchos' instead of 'tv' and 'watch'. > These names appear in status-bubbles on Bugzilla, so I was trying to keep > them small (similar to 'mac' instead of 'macos'). If keeping the bubbles small is a priority, that's fine. Comment on attachment 403886 [details]
Patch
Unofficial r=me. Code looks good.
Committed r264196: <https://trac.webkit.org/changeset/264196> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403886 [details]. Minor follow-up fix: https://trac.webkit.org/changeset/264327/webkit |