Bug 214144

Summary: Simplify BoxPtr::create
Product: WebKit Reporter: Xabier Rodríguez Calvar <calvaris>
Component: Web Template FrameworkAssignee: Xabier Rodríguez Calvar <calvaris>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, calvaris, cdumez, cmarcelo, darin, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Xabier Rodríguez Calvar 2020-07-09 09:24:00 PDT 
Fix what Darin commented on comment 29 of bug 212379
Comment 1 Xabier Rodríguez Calvar 2020-07-09 09:28:43 PDT 
Created attachment 403875 [details]
Patch
Comment 2 Darin Adler 2020-07-09 09:55:22 PDT 
Comment on attachment 403875 [details]
Patch

I also think that create is not the right word for something that takes ownership of an object. Maybe we need to rename those create functions to adopt.
Comment 3 EWS 2020-07-09 10:34:00 PDT 
Committed r264180: <https://trac.webkit.org/changeset/264180>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403875 [details].
Comment 4 Radar WebKit Bug Importer 2020-07-09 10:34:16 PDT 
<rdar://problem/65278265>