| Summary: | REGRESSION (r259840): Pressing Esc or ⌘+"." does not dismiss time picker on iOS | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||
| Component: | Forms | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bdakin, cdumez, hi, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Wenson Hsieh
2020-07-08 21:58:18 PDT
Created attachment 403898 [details]
Patch
Comment on attachment 403898 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403898&action=review > Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:379 > + if (elementType == InputType::Time || elementType == InputType::DateTimeLocal) I know this was already here... but is there a better way to know or infer the right set of types, instead of keeping a list here? Comment on attachment 403898 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403898&action=review Thanks for the review! >> Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:379 >> + if (elementType == InputType::Time || elementType == InputType::DateTimeLocal) > > I know this was already here... but is there a better way to know or infer the right set of types, instead of keeping a list here? That’s a good question. I don’t think there’s a way to know without poking around in UIKit internals, because the thing that actually steals FR in these controls is _UIDatePickerCalendarTimeLabel (an internal class). I think we could maybe make this consult -[UIDatePicker datePickerMode] and -[UIDatePicker datePickerStyle] instead, but the logic would look pretty similar to what we have already. Maybe in the distant future we could ask UIKit to vend an explicit bit for this. Comment on attachment 403898 [details] Patch (In reply to Tim Horton from comment #4) > Maybe in the distant future we could ask UIKit to vend an explicit bit for > this. 👍🏻 Committed r264187: <https://trac.webkit.org/changeset/264187> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403898 [details]. |