Bug 214104

Summary: Remove glBindFramebuffer flush workaround from ANGLE
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: ANGLEAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, graouts, jdarpinian, justin_fan, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 206625    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Kenneth Russell 2020-07-08 16:01:07 PDT 
In Bug 206625 a workaround was added to WebKit's snapshot of ANGLE to flush around calls to glBindFramebuffer on Intel GPUs as a potential way to address flakiness seen in layout tests after switching to the ANGLE backend.

However, it's very likely that jdarpinian@'s fix for Bug 208724, setting the EGL_ROBUST_RESOURCE_INITIALIZATION_ANGLE context creation attribute to true, fixed the underlying root cause.

The glBindFramebuffer flush workaround persists in WebKit's ANGLE snapshot, and should be removed as it's very likely unnecessary.
Comment 1 Kenneth Russell 2020-07-09 19:11:39 PDT 
Created attachment 403940 [details]
Patch
Comment 2 EWS Watchlist 2020-07-09 19:12:16 PDT 
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 EWS 2020-07-10 13:24:55 PDT 
Committed r264238: <https://trac.webkit.org/changeset/264238>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403940 [details].
Comment 4 Radar WebKit Bug Importer 2020-07-10 13:25:13 PDT 
<rdar://problem/65360176>