| Summary: | Add a fuzzing toggle for LICM | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> | ||||
| Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, fpizlo, ggaren, gskachkov, guijemont, jsc32, keith_miller, mark.lam, msaboff, rmorisset, ross.kirsling, ticaiolima, tuomas.webkit, tzagallo, webkit-bug-importer, ysuzuki | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Saam Barati
2020-07-08 12:21:34 PDT
Created attachment 403803 [details]
patch
Comment on attachment 403803 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=403803&action=review r=me > Source/JavaScriptCore/dfg/DFGLICMPhase.cpp:185 > + WeakRandom random { Options::seedForLICMFuzzer() }; Initialize it only when using with useLICMFuzzing. WeakRandom reads random seeds from entropy pool and this is super slow. Comment on attachment 403803 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=403803&action=review >> Source/JavaScriptCore/dfg/DFGLICMPhase.cpp:185 >> + WeakRandom random { Options::seedForLICMFuzzer() }; > > Initialize it only when using with useLICMFuzzing. WeakRandom reads random seeds from entropy pool and this is super slow. Even when it’s seeded? (In reply to Saam Barati from comment #3) > Comment on attachment 403803 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=403803&action=review > > >> Source/JavaScriptCore/dfg/DFGLICMPhase.cpp:185 > >> + WeakRandom random { Options::seedForLICMFuzzer() }; > > > > Initialize it only when using with useLICMFuzzing. WeakRandom reads random seeds from entropy pool and this is super slow. > > Even when it’s seeded? I've verified that this only does simple arithmetic when it's seeded. The default seed is "cryptographicallyRandomNumber()", which is probably what you're thinking about. Committed r264133: <https://trac.webkit.org/changeset/264133> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403803 [details]. |