Bug 214068

Summary:	REGRESSION (r264037) [GTK][WPE] accessibility/textarea-selected-text-range.html is failing for collapsed ranges
Product:	WebKit	Reporter:	Lauro Moura <lmoura>
Component:	Accessibility	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bugs-noreply, dpino, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=214017

Description Lauro Moura 2020-07-07 19:25:04 PDT

r264037 changed the behavior of AccessibilityRenderObject::setSelectedVisiblePositionRange for the cases where the selection range is 0.

This made accessibility/textarea-selected-text-range.html to fail, returning (0,0) from selectedTextRange when the length given to setSelectedTextRange is zero.

In AccessibilityUIElementAtk.cpp's AccessibilityUIElement::setSelectedTextRange(unsigned location, unsigned length), there is this snippet which might be related:

  1888     if (!length)
     1         return atk_text_set_caret_offset(ATK_TEXT(m_element.get()), location);
     2
     3     return atk_text_set_selection(ATK_TEXT(m_element.get()), 0, location, location + length);

Link to the results history: https://results.webkit.org/?suite=layout-tests&test=accessibility%2Ftextarea-selected-text-range.html

Comment 1 Radar WebKit Bug Importer 2020-07-07 19:25:16 PDT

<rdar://problem/65204399>

Comment 2 Lauro Moura 2020-07-08 21:09:56 PDT

264129 changed the test to wait for the expected results instead of checking right away due to the AccessibilityController async nature, causing it to timeout instead of fail.

Comment 3 Diego Pino 2020-10-06 07:55:46 PDT

Test is passing since r266295.