| Summary: | [Cocoa] Fix adjust-angle-include-paths.sh error seen building ANGLE library | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||
| Component: | Tools / Tests | Assignee: | Darin Adler <darin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ap, dino, ews-watchlist, graouts, kondapallykalyan, krollin, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Darin Adler
2020-07-07 14:26:59 PDT
Created attachment 403726 [details]
Patch
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE Comment on attachment 403726 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403726&action=review rs=me if Dean says so! > Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj:-4276 > - outputFileListPaths = ( > - ); > - outputPaths = ( > - ); Hmm, do we have the same for dynamic library target? No dependencies - bad for XCBuild. XCBuild doesn't use this Run Script build phase, so it's OK if there are no dependencies. Instead, the copy-and-mutate-header-files is done in the Copy Headers build phase. Committed r264116: <https://trac.webkit.org/changeset/264116> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403726 [details]. |