| Summary: | Heap Snapshot Object Graph view doesn't get populated in some cases when inspecting a JSContext | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Christopher Reid <chris.reid> | ||||||
| Component: | Web Inspector | Assignee: | Christopher Reid <chris.reid> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ews-watchlist, hi, inspector-bugzilla-changes, joepeck, ross.kirsling, toyoshim, webkit-bug-importer, yoshiaki.jitsukawa, yutak | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=214092 | ||||||||
| Attachments: |
|
||||||||
|
Description
Christopher Reid
2020-07-07 13:19:05 PDT
Created attachment 403723 [details]
patch
Comment on attachment 403723 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=403723&action=review > Source/WebInspectorUI/UserInterface/Views/HeapSnapshotDataGridTree.js:271 > + this.heapSnapshot.instancesWithClassName("CallbackGlobalObject", (instances) => { While this is fine, it would be nice to show all roots rather than just a specific few, as these roots may change in the future :) I believe we could expose a way to iterate `heapSnapshot._nodeOrdinalIsGCRoot`, calling `HeapSnapshot.prototype.serializeNode` on each. Comment on attachment 403723 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=403723&action=review >> Source/WebInspectorUI/UserInterface/Views/HeapSnapshotDataGridTree.js:271 >> + this.heapSnapshot.instancesWithClassName("CallbackGlobalObject", (instances) => { > > While this is fine, it would be nice to show all roots rather than just a specific few, as these roots may change in the future :) > > I believe we could expose a way to iterate `heapSnapshot._nodeOrdinalIsGCRoot`, calling `HeapSnapshot.prototype.serializeNode` on each. this can be done as a FIXME followup bug, or behind a `WI.Setting` btw :) (In reply to Devin Rousso from comment #3) > Comment on attachment 403723 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=403723&action=review > > >> Source/WebInspectorUI/UserInterface/Views/HeapSnapshotDataGridTree.js:271 > >> + this.heapSnapshot.instancesWithClassName("CallbackGlobalObject", (instances) => { > > > > While this is fine, it would be nice to show all roots rather than just a specific few, as these roots may change in the future :) > > > > I believe we could expose a way to iterate `heapSnapshot._nodeOrdinalIsGCRoot`, calling `HeapSnapshot.prototype.serializeNode` on each. > > this can be done as a FIXME followup bug, or behind a `WI.Setting` btw :) Yeah that would be good to have. I created a followup bug https://webkit.org/b/214092 and will point a FIXME to it when landing. Created attachment 403798 [details]
Patch for landing
Committed r264124: <https://trac.webkit.org/changeset/264124> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403798 [details]. |