| Summary: | Add WebCoreNSURLSession SPI to send HTTP/2 ping | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | cdumez, cgarcia, eric.carlson, ews-watchlist, glenn, japhet, jer.noble, philipj, sam, sergio, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | 214747 | ||||||||||||
| Bug Blocks: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Alex Christensen
2020-07-06 20:56:39 PDT
Created attachment 403661 [details]
Patch
Created attachment 403662 [details]
Patch
Created attachment 403664 [details]
Patch
Comment on attachment 403664 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403664&action=review > Source/WebCore/loader/FrameLoaderClient.h:361 > + virtual void sendH2Ping(const URL&, CompletionHandler<void(Expected<Seconds, ResourceError>&&)>&&); This should be pure-virtual. By moving the ASSERT to WebKitLegacy, it will make it clear if it ever gets called that it is WebKitLegacy that has not implemented it. > Source/WebCore/platform/graphics/PlatformMediaResourceLoader.h:70 > + virtual void sendH2Ping(const URL&, CompletionHandler<void(Expected<Seconds, ResourceError>&&)>&&); Same here. This should be pure-virtual. Created attachment 403695 [details]
Patch
Committed r264021: <https://trac.webkit.org/changeset/264021> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403695 [details]. |