Bug 214006

Summary:

W3C test importer should be able to update just the imported tests (without adding new directories for different test specs.)

Product:

WebKit

Reporter:

Carlos Alberto Lopez Perez <clopez>

Component:

Tools / Tests

Assignee:

Sam Sneddon [:gsnedders] <gsnedders>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, clopez, ews-watchlist, glenn, gsnedders, jbedard, slewis, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=213927

Bug Depends on:

Bug Blocks:

207734

Attachments:

Description	Flags
Patch	none
Patch	clopez: review?

Description Carlos Alberto Lopez Perez 2020-07-06 13:57:55 PDT

The process for updating all the WPT imported tests its the following (AFAIK):

1. Raise the WPT commit in LayoutTests/imported/w3c/resources/TestRepositories
2. Run the importer script: Tools/Scripts/import-w3c-tests


The problem is that when you try this, then you find that the importer script adds many new directories from test suites still not imported.
Basically is adding every directory from wpt that its not explicitly listed as skipped at LayoutTests/imported/w3c/resources/import-expectations.json


I think it would be useful to have a way of telling the tool to only update the tests already imported but without adding new folders for unrelated tests.

This is perhaps a happening since r206993 but not sure.

Comment 1 Carlos Alberto Lopez Perez 2020-07-06 15:20:56 PDT

Created attachment 403627 [details]
Patch

Comment 2 Carlos Alberto Lopez Perez 2020-07-06 19:50:43 PDT

Created attachment 403656 [details]
Patch

Comment 3 Carlos Alberto Lopez Perez 2020-07-07 09:20:02 PDT

Note... this is supposed to be executed as:

1. Raise the WPT commit in LayoutTests/imported/w3c/resources/TestRepositories
2. Run the importer script (without passing any folder name, only the update-import switch): Tools/Scripts/import-w3c-tests --update-import -v

Comment 4 Radar WebKit Bug Importer 2020-09-21 15:36:41 PDT

<rdar://problem/69332004>

Comment 5 Sam Sneddon [:gsnedders] 2023-07-04 09:01:03 PDT

To make sure I understand what the goal here is:

Unlike passing a set of test paths on the command line, the aim is to simply update an existing partial import of WPT without importing test suites for new/other specifications?

If so, I think I'd rather than the current patch here:

 * Instead of using the presence of META.yml, just look at top-level directories of WPT and direct children of css/.
 * Add everything we're skipping to import-expectations.json (as "skip", to make it clear what we're not importing).

That said, could we not achieve the same goal by having the top-level marked as "skip" and then just allowlisting everything we want to import? Though that does have the one downside of making it easy to miss new directories we actually do want to import, versus explicitly adding everything new as "skip".

Comment 6 Sam Sneddon [:gsnedders] 2023-10-27 08:24:16 PDT

Pull request: https://github.com/WebKit/WebKit/pull/19642

Comment 7 EWS 2023-12-15 04:42:31 PST

Committed 272109@main (e5fd5e058c53): <https://commits.webkit.org/272109@main>

Reviewed commits have been landed. Closing PR #19642 and removing active labels.