Bug 214005

Summary:

Cleanup WebVideoFullscreenControllerAVKit.mm and PlaybackSessionInterfaceAVKit.mm

Product:

WebKit

Reporter:

Peng Liu <peng.liu6>

Component:

New Bugs

Assignee:

Peng Liu <peng.liu6>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Peng Liu 2020-07-06 13:44:16 PDT

Cleanup WebVideoFullscreenControllerAVKit.mm and PlaybackSessionInterfaceAVKit.mm

Comment 1 Peng Liu 2020-07-06 13:47:11 PDT

Created attachment 403616 [details]
Patch

Comment 2 Daniel Bates 2020-07-06 13:51:09 PDT

Comment on attachment 403616 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403616&action=review

> Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.mm:30
> +#if PLATFORM(COCOA) && HAVE(AVKIT)

Optimal patch removes the PLATFORM(COCOA) if this file is never built on non-Cocoa platforms (e.g. Windows).

Comment 3 EWS 2020-07-06 15:04:45 PDT

Committed r263990: <https://trac.webkit.org/changeset/263990>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403616 [details].

Comment 4 Radar WebKit Bug Importer 2020-07-06 15:05:16 PDT

<rdar://problem/65150171>