Bug 213985

Summary: [iPadOS] Unable to change focus between Google Docs windows by tapping
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit2Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bdakin, darin, ews-watchlist, gyuyoung.kim, hi, megan_gardner, ryuan.choi, sergio, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
For EWS
none
Fix GTK/WPE builds
none
Patch none

Description Wenson Hsieh 2020-07-05 22:16:50 PDT 
<rdar://problem/57083267>
Comment 1 Wenson Hsieh 2020-07-05 23:31:39 PDT Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2020-07-05 23:45:11 PDT Comment hidden (obsolete)
Comment 3 Wenson Hsieh 2020-07-06 09:08:27 PDT 
Created attachment 403598 [details]
Patch
Comment 4 Darin Adler 2020-07-06 11:48:18 PDT 
Comment on attachment 403598 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403598&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1504
> +        if (nativeWebTouchEvent.isPotentialTap() && self.hasHiddenContentEditable && self._hasFocusedElement && !self.window.keyWindow)
> +            [self.window makeKeyWindow];

Does the test cover all 4 of these changes?
Comment 5 Wenson Hsieh 2020-07-06 11:51:00 PDT 
Comment on attachment 403598 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403598&action=review

>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1504
>> +            [self.window makeKeyWindow];
> 
> Does the test cover all 4 of these changes?

Unfortunately, the new test doesn’t cover the change in `-mouseGestureRecognizerChanged:` (since there’s currently no way to simulate real trackpad-y mouse events from WebKitTestRunner at the moment).

The three other changes here are covered, however.
Comment 6 Wenson Hsieh 2020-07-06 11:57:55 PDT 
(In reply to Wenson Hsieh from comment #5)
> Comment on attachment 403598 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=403598&action=review
> 
> >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1504
> >> +            [self.window makeKeyWindow];
> > 
> > Does the test cover all 4 of these changes?
> 
> Unfortunately, the new test doesn’t cover the change in
> `-mouseGestureRecognizerChanged:` (since there’s currently no way to
> simulate real trackpad-y mouse events from WebKitTestRunner at the moment).

I filed <https://bugs.webkit.org/show_bug.cgi?id=213995> to track this.

> 
> The three other changes here are covered, however.
Comment 7 EWS 2020-07-06 12:45:58 PDT 
Committed r263979: <https://trac.webkit.org/changeset/263979>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403598 [details].