| Summary: | [Flatpak SDK] Misc updates | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||||
| Component: | Tools / Tests | Assignee: | Philippe Normand <pnormand> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | clopez, svillar, webkit-bug-importer, zan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Philippe Normand
2020-07-05 02:51:00 PDT
Created attachment 403550 [details]
Patch
Comment on attachment 403550 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403550&action=review > Tools/flatpak/flatpakutils.py:1034 > + runner_args.append("--%s" % arg[10:]) Perhaps we need some clarification about this magic number Created attachment 403579 [details]
Patch
Comment on attachment 403579 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403579&action=review > Tools/flatpak/flatpakutils.py:1035 > + opt_prefix = "--flatpak-" > + for arg in args: > + if arg.startswith(opt_prefix): > + runner_args.append("--%s" % arg[len(opt_prefix):]) Thanks, I think it looks better now. Committed r263963: <https://trac.webkit.org/changeset/263963> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403579 [details]. |