| Summary: | WebCore/Sources.txt: Remove #if ENABLE_GAMEPAD | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||
| Component: | WebCore Misc. | Assignee: | Darin Adler <darin> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | annulen, ews-watchlist, gyuyoung.kim, ryuan.choi, sam, sergio, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 212420 | ||||||||
| Attachments: |
|
||||||||
|
Description
Darin Adler
2020-07-03 13:23:28 PDT
Created attachment 403475 [details]
Patch
Comment on attachment 403475 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403475&action=review > Source/WebCore/ChangeLog:8 > + * Sources.txt: Remove #if ENABLE_APPLICATION_MANIFEST and sort files in with the others. Oops, this should say ENABLE_GAMEPAD. Looks like I need to modify something so the empty source files get generated, since I am getting this error in the GTK build:
Cannot find source file:
/app/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp
Maybe the perl scripts need to be changed so they generate an empty file rather than no file at all. Or perhaps a file with a comment "/* This file intentionally left empty. */" in it?
Hmm, no it seems the real problem is that this same error is repeated in the CMake files, where we conditionalize compilation there instead of in the code. I will make the same change to CMake, I guess. That's going to make this more of a pain, but I think it's the right thing to do. Created attachment 403482 [details]
Patch
Committed r263910: <https://trac.webkit.org/changeset/263910> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403482 [details]. |