Bug 213931

Summary:

Add "-Wliteral-conversion" warning to Xcode based builds and fix the issues it finds

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, darin, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Sam Weinig 2020-07-03 11:21:48 PDT

Add "-Wliteral-conversion" warning to Xcode based builds and fix the issues it finds

Comment 1 Sam Weinig 2020-07-03 11:25:42 PDT

Created attachment 403471 [details]
Patch

Comment 2 EWS 2020-07-03 13:31:02 PDT

Committed r263906: <https://trac.webkit.org/changeset/263906>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403471 [details].

Comment 3 Radar WebKit Bug Importer 2020-07-03 13:32:19 PDT

<rdar://problem/65082658>

Comment 4 Alexey Proskuryakov 2020-07-03 17:12:01 PDT

I see that two of the three issues fixed are about debug background, but us the remaining one untestable?

Comment 5 Darin Adler 2020-07-03 21:43:42 PDT

(In reply to Alexey Proskuryakov from comment #4)
> I see that two of the three issues fixed are about debug background, but us
> the remaining one untestable?

All three are about debug background.