Bug 213922

Summary: Fix potential pixel buffer leak in ImageRotationSessionVT::rotate
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, jer.noble, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description youenn fablet 2020-07-03 04:54:29 PDT 
Fix potential pixel buffer leak in ImageRotationSessionVT::rotate
Comment 1 youenn fablet 2020-07-03 05:19:47 PDT 
Created attachment 403452 [details]
Patch
Comment 2 youenn fablet 2020-07-03 05:20:13 PDT 
<rdar://problem/64133927>
Comment 3 youenn fablet 2020-07-03 05:21:11 PDT 
Looking at other WebKit code, I am wondering whether we should not add both kCVPixelBufferIOSurfacePropertiesKey and kCVPixelFormatOpenGLESCompatibility/kCVPixelBufferOpenGLCompatibilityKey like done in ImageTransferSession.
Comment 4 youenn fablet 2020-07-03 07:51:11 PDT 
Created attachment 403459 [details]
Patch
Comment 5 EWS 2020-07-07 12:17:35 PDT 
Committed r264034: <https://trac.webkit.org/changeset/264034>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403459 [details].
Comment 6 Darin Adler 2020-07-07 12:28:28 PDT 
Comment on attachment 403459 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403459&action=review

> Source/WebCore/platform/graphics/cv/ImageRotationSessionVT.mm:118
> +    result = adoptCF(rawRotatedBuffer);

I would use auto here rather than defining result above.