Bug 213920

Summary: [Flatpak SDK] Unable to build without Internet connection
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: Tools / TestsAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: pnormand, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Sergio Villar Senin 2020-07-03 00:21:56 PDT
Building flatpak based environment
Traceback (most recent call last):
  File "~/WebKit/Tools/Scripts/webkit-flatpak", line 28, in <module>
    sys.exit(WebkitFlatpak.load_from_args().run())
  File "~/WebKit/Tools/flatpak/flatpakutils.py", line 866, in run
    return self.main()
  File "~/WebKit/Tools/flatpak/flatpakutils.py", line 862, in main
    return self.setup_dev_env()
  File "~/WebKit/Tools/flatpak/flatpakutils.py", line 929, in setup_dev_env
    for package in self._get_packages():
  File "~/WebKit/Tools/flatpak/flatpakutils.py", line 962, in _get_packages
    FlatpakRepo("flathub", repo_file="https://dl.flathub.org/repo/flathub.flatpakrepo")
  File "~/WebKit/Tools/flatpak/flatpakutils.py", line 303, in __init__
    repo.read(self.repo_file.name)
  File "~/WebKit/Tools/flatpak/flatpakutils.py", line 335, in repo_file
    self._repo_file.write(urlopen(self.repo_file_name).read())
  File "/usr/lib/python2.7/urllib2.py", line 154, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/lib/python2.7/urllib2.py", line 429, in open
    response = self._open(req, data)
  File "/usr/lib/python2.7/urllib2.py", line 447, in _open
    '_open', req)
  File "/usr/lib/python2.7/urllib2.py", line 407, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 1241, in https_open
    context=self._context)
  File "/usr/lib/python2.7/urllib2.py", line 1198, in do_open
    raise URLError(err)
urllib2.URLError: <urlopen error [Errno 101] Network is unreachable>
Comment 1 Philippe Normand 2020-07-03 02:08:58 PDT
Ah flathub... I have a patch removing this code.

But meanwhile we could have all=True kw arg in _get_packages(). If it's False the workaround would be to not create the flathub FlatpakRepo, as it's not needed anyway from this call-site (setup_dev_env).
Comment 2 Philippe Normand 2020-07-08 05:02:13 PDT
Created attachment 403771 [details]
Patch
Comment 3 EWS 2020-07-09 04:43:39 PDT
Committed r264165: <https://trac.webkit.org/changeset/264165>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403771 [details].
Comment 4 Radar WebKit Bug Importer 2020-07-09 04:44:15 PDT
<rdar://problem/65267128>