Bug 213913

Summary:

Add testing infrastructure and SPI declaration for HTTP/2 ping

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, ews-watchlist, jer.noble, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Alex Christensen 2020-07-02 18:02:19 PDT

Add testing infrastructure and SPI declaration for HTTP/2 ping

Comment 1 Alex Christensen 2020-07-02 18:04:37 PDT

Created attachment 403426 [details]
Patch

Comment 2 Jer Noble 2020-07-02 18:14:22 PDT

Comment on attachment 403426 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403426&action=review

r=me with single nit.

> Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:77
> +- (void) getUnderlyingHTTPConnectionInfoWithCompletionHandler:(void (^)(_NSHTTPConnectionInfo *connectionInfo))completionHandler;

Nit: Whitespace between ")" and "get..."

Comment 3 Alex Christensen 2020-07-02 18:17:56 PDT

Created attachment 403429 [details]
Patch

Comment 4 EWS 2020-07-02 19:01:25 PDT

Committed r263879: <https://trac.webkit.org/changeset/263879>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403429 [details].

Comment 5 Radar WebKit Bug Importer 2020-07-02 19:02:18 PDT

<rdar://problem/65060003>