Bug 213909

Summary: GameController.framework soft linking refactoring
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
thorton: review+
Patch for landing none

Description Brady Eidson 2020-07-02 17:19:06 PDT 
GameController.framework soft linking refactoring

We'll soon need to use GC.framework in multiple places, so it's time to refactor it out into its own files.

(Also add a soon-to-be-needed SPI header while I'm at it)
Comment 1 Brady Eidson 2020-07-02 17:20:55 PDT 
Created attachment 403420 [details]
Patch
Comment 2 Tim Horton 2020-07-02 17:23:46 PDT 
Comment on attachment 403420 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403420&action=review

> Source/WebCore/platform/gamepad/cocoa/GameControllerSPI.h:33
> +WTF_EXTERN_C_BEGIN

This should include a fixme with a radar where you ask for the headers to be fixed.

> Source/WebCore/platform/gamepad/cocoa/GameControllerSoftLink.mm:33
> +SOFT_LINK_FRAMEWORK_FOR_SOURCE(WebCore, GameController)

I think you lost the optionality here?
Comment 3 Brady Eidson 2020-07-02 17:25:36 PDT 
(In reply to Tim Horton from comment #2)
> Comment on attachment 403420 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=403420&action=review
> 
> > Source/WebCore/platform/gamepad/cocoa/GameControllerSPI.h:33
> > +WTF_EXTERN_C_BEGIN
> 
> This should include a fixme with a radar where you ask for the headers to be
> fixed.

Sure.

> 
> > Source/WebCore/platform/gamepad/cocoa/GameControllerSoftLink.mm:33
> > +SOFT_LINK_FRAMEWORK_FOR_SOURCE(WebCore, GameController)
> 
> I think you lost the optionality here?

Actually not - Using the Header/Source softlink for a Framework always has optionality.

(You'll see that used in the next patch!
Comment 4 Brady Eidson 2020-07-02 17:28:02 PDT 
Created attachment 403422 [details]
Patch for landing
Comment 5 EWS 2020-07-02 18:05:40 PDT 
Committed r263878: <https://trac.webkit.org/changeset/263878>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403422 [details].
Comment 6 Radar WebKit Bug Importer 2020-07-02 18:06:20 PDT 
<rdar://problem/65058543>