Bug 213793

Summary: REGRESSION (r207558): [Mac] Context clicks on links sometimes result in navigations
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, cgarcia, ggaren, megan_gardner, opendarwin, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 163292    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Andy Estes 2020-06-30 07:01:32 PDT 
[Mac] Context clicks on links sometimes result in navigations
Comment 1 Andy Estes 2020-06-30 07:01:51 PDT Comment hidden (obsolete)
Comment 2 Andy Estes 2020-07-02 22:19:40 PDT 
rdar://problem/64294015
Comment 3 Andy Estes 2020-07-03 00:13:50 PDT Comment hidden (obsolete)
Comment 4 Andy Estes 2020-07-03 00:20:21 PDT Comment hidden (obsolete)
Comment 5 Andy Estes 2020-07-07 22:46:23 PDT 
Created attachment 403759 [details]
Patch
Comment 6 Tim Horton 2020-07-07 23:29:35 PDT 
Comment on attachment 403759 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403759&action=review

Delightful!

> Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:62
> +      <CommandLineArguments>
> +         <CommandLineArgument
> +            argument = "--gtest_filter=&quot;WebKit.ContextMenuControlClick&quot;"
> +            isEnabled = "YES">
> +         </CommandLineArgument>
> +      </CommandLineArguments>
> +      <AdditionalOptions>
> +      </AdditionalOptions>

Please revert this part!
Comment 7 Andy Estes 2020-07-08 09:33:08 PDT 
(In reply to Tim Horton from comment #6)
> Comment on attachment 403759 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=403759&action=review
> 
> Delightful!

☺️

> 
> > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:62
> > +      <CommandLineArguments>
> > +         <CommandLineArgument
> > +            argument = "--gtest_filter=&quot;WebKit.ContextMenuControlClick&quot;"
> > +            isEnabled = "YES">
> > +         </CommandLineArgument>
> > +      </CommandLineArguments>
> > +      <AdditionalOptions>
> > +      </AdditionalOptions>
> 
> Please revert this part!

😬
Comment 8 Andy Estes 2020-07-08 10:05:52 PDT 
Created attachment 403793 [details]
Patch
Comment 9 EWS 2020-07-08 10:44:01 PDT 
Committed r264113: <https://trac.webkit.org/changeset/264113>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403793 [details].