Bug 213769

Summary:

[TestExpectations] Add architecture for Apple's ports

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, ews-watchlist, glenn, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=213761

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description Jonathan Bedard 2020-06-29 19:50:06 PDT

Apple's ports need to support architecture modifiers in test expectations, this is particularly important for for supporting Apple Silicon.

Comment 1 Radar WebKit Bug Importer 2020-06-29 19:54:50 PDT

<rdar://problem/64920013>

Comment 2 Jonathan Bedard 2020-06-29 20:18:45 PDT

Created attachment 403166 [details]
Patch

Comment 3 Jonathan Bedard 2020-06-29 20:19:56 PDT

Turns out, we already have support for this. We should still refactor our test expectation parser, it's far more complicated than it needs to be.

Comment 4 Aakash Jain 2020-06-30 07:14:53 PDT

rs=me

Comment 5 Jonathan Bedard 2020-06-30 07:28:19 PDT

Created attachment 403197 [details]
Patch for landing

Comment 6 EWS 2020-06-30 07:48:43 PDT

Committed r263749: <https://trac.webkit.org/changeset/263749>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403197 [details].