Bug 213766

Summary: Remove WTF::MD5
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, benjamin, cdumez, cmarcelo, ews-watchlist, galpeter, gyuyoung.kim, ryuan.choi, sergio, toyoshim, webkit-bug-importer, youennf, yutak
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2020-06-29 17:44:28 PDT
Remove WTF::MD5
Attachments
Patch (20.48 KB, patch)
2020-06-29 17:45 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (20.62 KB, patch)
2020-06-29 17:50 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (45.69 KB, patch)
2020-06-29 18:20 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (45.72 KB, patch)
2020-06-29 18:40 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-06-29 17:45:39 PDT
Created attachment 403145 [details] Patch
Alex Christensen
Comment 2 2020-06-29 17:50:26 PDT
Created attachment 403146 [details] Patch
Alex Christensen
Comment 3 2020-06-29 18:20:17 PDT
Created attachment 403151 [details] Patch
Alex Christensen
Comment 4 2020-06-29 18:40:41 PDT
Created attachment 403156 [details] Patch
youenn fablet
Comment 5 2020-06-30 04:56:18 PDT
Comment on attachment 403156 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403156&action=review > Source/WebCore/platform/network/curl/CurlCacheEntry.cpp:223 > baseNameBuilder.append(hex(rawdata[i], Lowercase)); This might break existing network cache. I think that is fine. If not, I guess CURL port can add back MD5 in CURL specific files.
EWS
Comment 6 2020-06-30 10:26:27 PDT
Committed r263759: <https://trac.webkit.org/changeset/263759> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403156 [details].
Radar WebKit Bug Importer
Comment 7 2020-06-30 10:27:20 PDT
<rdar://problem/64944843>
Note You need to log in before you can comment on or make changes to this bug.