Bug 213719

Summary:

checked overflow in WebCore::findClosestFont

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Text

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ddkilzer, mmaxfield

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
patch	none

Description Antti Koivisto 2020-06-29 02:54:35 PDT

6 WebCore: WebCore::findClosestFont(WebCore::FontDatabase::InstalledFontFamily const&, WebCore::FontSelectionRequest) <==
        6 WebCore: WebCore::findClosestFont(WebCore::FontDatabase::InstalledFontFamily const&, WebCore::FontSelectionRequest)
          6 WebCore: WebCore::FontCache::createFontPlatformData(WebCore::FontDescription const&, WTF::AtomicString const&, WebCore::FontTaggedSettings<int> const*, WebCore::FontVariantSettings const*, WebCore::FontSelectionSpecifiedCapabilities)
            6 WebCore: WebCore::FontCache::getCachedFontPlatformData(WebCore::FontDescription const&, WTF::AtomicString const&, WebCore::FontTaggedSettings<int> const*, WebCore::FontVariantSettings const*, WebCore::FontSelectionSpecifiedCapabilities, bool)

Comment 1 Antti Koivisto 2020-06-29 02:55:11 PDT

<rdar://47765225>

Comment 2 Antti Koivisto 2020-06-29 03:04:02 PDT

Created attachment 403044 [details]
patch

Comment 3 Antti Koivisto 2020-06-29 03:05:23 PDT

Created attachment 403045 [details]
patch

Comment 4 David Kilzer (:ddkilzer) 2020-06-29 04:16:45 PDT

Comment on attachment 403045 [details]
patch

r=me

Comment 5 EWS 2020-06-29 04:31:14 PDT

Committed r263654: <https://trac.webkit.org/changeset/263654>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403045 [details].