| Summary: | RunLoop::dispatch should only call wakeUp when needed | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Geoffrey Garen <ggaren> | ||||||||||||||
| Component: | New Bugs | Assignee: | Geoffrey Garen <ggaren> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | andersca, beidson, benjamin, cdumez, cmarcelo, ews-watchlist, sam, sihui_liu, webkit-bug-importer | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Geoffrey Garen
2020-06-28 16:05:09 PDT
Created attachment 403013 [details]
Patch
Comment on attachment 403013 [details]
Patch
Oops! I had planned to remove the functionsHandled behavior separately from this patch -- but it's actually not correct until you do both, since functionsHandled is willing to exit without a wakeUp. :(
Created attachment 403014 [details]
Patch
Comment on attachment 403014 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403014&action=review > Source/WTF/ChangeLog:10 > + RunLoop::wakeUp is super expensive (at least on Darwin platforms). Back > + when IndexedDB used RunLoop::dispatch, RunLoop::wakeUp accounted for 15% > + of all database lookup time. Out of interest (and for the historical record) what makes it so expensive? Most of the cost seemed to be its usage of pthread mutexes. (In reply to Geoffrey Garen from comment #5) > Most of the cost seemed to be its usage of pthread mutexes. Is "its" here CFRunLoopWakeUp()? Or something we are doing in WTF? Created attachment 403027 [details]
Patch
> Is "its" here CFRunLoopWakeUp()? Or something we are doing in WTF?
It's CFRunLoopSourceSignal and CFRunLoopWakeUp.
Created attachment 403264 [details]
Patch
Created attachment 403343 [details]
Patch
Created attachment 403408 [details]
Patch
Comment on attachment 403408 [details]
Patch
Looks like EWS is happy now.
Committed r263973: <https://trac.webkit.org/changeset/263973> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403408 [details]. |