| Summary: | [iOS] Clean up visible position comparisons in WebPage::requestDocumentEditingContext() | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||
| Component: | WebKit Misc. | Assignee: | Daniel Bates <dbates> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ggaren, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Local Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Daniel Bates
2020-06-28 11:46:38 PDT
Created attachment 403003 [details]
Patch
Comment on attachment 403003 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403003&action=review > Source/WebKit/ChangeLog:12 > + are unlikely to effect code generation. If they do, they make things a tiny bit more > + efficient. To be precise, only the latter makes things a tiny bit more efficient. Comment on attachment 403003 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403003&action=review r=me > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:4183 > + startOfRangeOfInterestInSelection = std::max<VisiblePosition>(rangeOfInterestStart, selectionStart); > + endOfRangeOfInterestInSelection = std::min<VisiblePosition>(rangeOfInterestEnd, selectionEnd); No need to specify <VisiblePosition> when both arguments are <VisiblePosition>. Comment on attachment 403003 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403003&action=review Thanks for the review, Geoff! >> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:4183 >> + endOfRangeOfInterestInSelection = std::min<VisiblePosition>(rangeOfInterestEnd, selectionEnd); > > No need to specify <VisiblePosition> when both arguments are <VisiblePosition>. OK. Created attachment 403004 [details]
To Land
Comment on attachment 403004 [details] To Land Clearing flags on attachment: 403004 Committed r263634: <https://trac.webkit.org/changeset/263634> All reviewed patches have been landed. Closing bug. |