Bug 213680

Summary: Convert AppCache manifest parser over to using StringParsingBuffer
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, darin, esprehn+autocc, ews-watchlist, gyuyoung.kim, japhet, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Sam Weinig 2020-06-27 09:09:05 PDT 
Convert AppCache manifest parser over to using StringParsingBuffer
Comment 1 Sam Weinig 2020-06-27 12:42:22 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2020-06-27 13:50:54 PDT Comment hidden (obsolete)
Comment 3 Sam Weinig 2020-06-28 12:15:14 PDT Comment hidden (obsolete)
Comment 4 Sam Weinig 2020-06-28 18:02:58 PDT Comment hidden (obsolete)
Comment 5 Sam Weinig 2020-06-28 18:30:19 PDT Comment hidden (obsolete)
Comment 6 Sam Weinig 2020-06-28 20:21:18 PDT Comment hidden (obsolete)
Comment 7 Sam Weinig 2020-06-29 17:33:14 PDT 
Created attachment 403143 [details]
Patch
Comment 8 Darin Adler 2020-06-29 20:27:34 PDT 
Comment on attachment 403143 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403143&action=review

> Source/WebCore/loader/appcache/ManifestParser.cpp:77
> +    static constexpr const char cacheManifestMIMEType[] = "text/cache-manifest";

Do we need "const"?
Comment 9 EWS 2020-06-29 20:52:21 PDT 
Committed r263722: <https://trac.webkit.org/changeset/263722>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403143 [details].
Comment 10 Radar WebKit Bug Importer 2020-06-29 20:53:11 PDT 
<rdar://problem/64921638>