Bug 213585

Summary: Running spellcheck on https://developer.apple.com/forums/thread/650317 hangs the web process
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, darin, ews-watchlist, megan_gardner, mifenton, simon.fraser, thorton, timothy, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Fix IOS_FAMILY build none

Description Wenson Hsieh 2020-06-24 17:49:54 PDT 
Steps (macOS):
1. Load https://developer.apple.com/forums/thread/650317
2. Click "Reply to this question"
   (Sign in with an Apple ID if needed)
4. Focus the comment box
5. Press CMD+; to trigger spellchecking.

The web content process hangs indefinitely as a result.
Comment 1 Wenson Hsieh 2020-06-24 17:56:30 PDT 
<rdar://problem/64681632>
Comment 2 Wenson Hsieh 2020-06-24 18:05:50 PDT Comment hidden (obsolete)
Comment 3 Darin Adler 2020-06-24 18:08:33 PDT 
Comment on attachment 402703 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402703&action=review

> Source/WebCore/testing/Internals.idl:383
> +    void advanceToNextMisspelling();

How can this be unconditional if the declaration in the .h file is inside an #if?
Comment 4 Wenson Hsieh 2020-06-24 18:10:16 PDT 
(In reply to Darin Adler from comment #3)
> Comment on attachment 402703 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=402703&action=review
> 
> > Source/WebCore/testing/Internals.idl:383
> > +    void advanceToNextMisspelling();
> 
> How can this be unconditional if the declaration in the .h file is inside an
> #if?

Indeed, this breaks the IOS_FAMILY build 😅. Trying to fix it now.
Comment 5 Wenson Hsieh 2020-06-24 18:15:50 PDT 
Created attachment 402705 [details]
Fix IOS_FAMILY build
Comment 6 Wenson Hsieh 2020-06-24 21:29:02 PDT 
Comment on attachment 402705 [details]
Fix IOS_FAMILY build

Thanks for the review!
Comment 7 EWS 2020-06-24 21:42:16 PDT 
Committed r263499: <https://trac.webkit.org/changeset/263499>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402705 [details].