| Summary: | No scrolling momentum with 'scroll-snap-type: x mandatory' if the scroller scrolls vertically | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||||||
| Component: | Scrolling | Assignee: | Martin Robinson <mrobinson> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | mrobinson, simon.fraser, webkit-bug-importer, wenson_hsieh | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | Safari Technology Preview | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | |||||||||||||||
| Bug Blocks: | 218115 | ||||||||||||||
| Attachments: |
|
||||||||||||||
Created attachment 423727 [details]
Patch
Comment on attachment 423727 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423727&action=review > LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-momentum-in-non-snapping-axis.html:34 > + } catch (e) { > + console.log(e); Is this necessary? Created attachment 423751 [details]
Patch
(In reply to Simon Fraser (smfr) from comment #5) > > LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-momentum-in-non-snapping-axis.html:34 > > + } catch (e) { > > + console.log(e); > > Is this necessary? Unfortunately this is because Promises will otherwise eat exceptions and they won't be printed in test output. Created attachment 423752 [details]
Patch
Created attachment 423816 [details]
Patch
Committed r274853: <https://commits.webkit.org/r274853> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423816 [details]. |
Created attachment 402673 [details] Testcase In the attached testcase, there is no vertical scrolling momentum in Safari. There is in Firefox.