| Summary: | Black rectangle appears when closing PIP on iPhone | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Peng Liu <peng.liu6> | ||||
| Component: | New Bugs | Assignee: | Peng Liu <peng.liu6> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Peng Liu
2020-06-24 12:06:08 PDT
Created attachment 402678 [details]
Patch
Comment on attachment 402678 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402678&action=review > Source/WebCore/ChangeLog:10 > + Don't unhide the window and view of WebAVPlayerViewController before exiting Picture-in-Picture. I think it is worth saying where m_window will be made visible, e.g. "... before exiting Picture-in-Picture because m_window will be shown ..." Comment on attachment 402678 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402678&action=review >> Source/WebCore/ChangeLog:10 >> + Don't unhide the window and view of WebAVPlayerViewController before exiting Picture-in-Picture. > > I think it is worth saying where m_window will be made visible, e.g. "... before exiting Picture-in-Picture because m_window will be shown ..." Thanks for the review! Actually both m_window and m_playerViewController will be destroyed after exiting picture-in-picture. So I think we don't need to show them before destroying them unless there is some animation issue (I haven't found any issue in tests yet). Committed r263492: <https://trac.webkit.org/changeset/263492> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402678 [details]. |