Bug 213531

Summary: Web Inspector: add a tooltip to the icon of overridden resources to clarify meaning
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
bburg: review+
Patch none

Description Devin Rousso 2020-06-23 14:02:42 PDT
The inverted icon is not immediately explanatory (although it is quickly identifiable), so we should add a `title` to provide it.
Comment 1 Devin Rousso 2020-06-23 14:06:51 PDT
Created attachment 402589 [details]
Patch
Comment 2 BJ Burg 2020-06-23 15:43:52 PDT
Comment on attachment 402589 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402589&action=review

r=me

> Source/WebInspectorUI/ChangeLog:30
> +        Add a `title` to the overriden resource icon that clarifies the fact that the resource was

Nit: overridden

> Source/WebInspectorUI/UserInterface/Views/DataGridNode.js:410
> +        // Subclasses may override

Nit: trailing period
Comment 3 Devin Rousso 2020-06-23 15:54:58 PDT
Created attachment 402601 [details]
Patch
Comment 4 EWS 2020-06-23 16:21:43 PDT
Committed r263429: <https://trac.webkit.org/changeset/263429>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402601 [details].
Comment 5 Radar WebKit Bug Importer 2020-06-23 16:22:14 PDT
<rdar://problem/64669960>