| Summary: | [WebDriver][WPE] Allow running Selenium tests with the WPE WebDriver | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Lauro Moura <lmoura> | ||||||
| Component: | WPE WebKit | Assignee: | Lauro Moura <lmoura> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bugs-noreply, cgarcia, ews-watchlist, glenn, jbedard | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 213916 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Lauro Moura
2020-06-22 20:20:29 PDT
Created attachment 402530 [details]
Patch
Comment on attachment 402530 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402530&action=review > WebDriverTests/imported/selenium/py/conftest.py:48 > + 'WPEWebKit', I guess I forgot this on the selenium patch. Changes to this file should be done upstream, and then reimport. > WebDriverTests/imported/selenium/py/conftest.py:125 > + if driver_class == 'WPEWebKit': This is not correctly indented, no? (In reply to Carlos Garcia Campos from comment #2) > Comment on attachment 402530 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=402530&action=review > > > WebDriverTests/imported/selenium/py/conftest.py:48 > > + 'WPEWebKit', > > I guess I forgot this on the selenium patch. Changes to this file should be > done upstream, and then reimport. Right. I've added a patch to bug213916 with the upstream version with this fix already merged. > > > WebDriverTests/imported/selenium/py/conftest.py:125 > > + if driver_class == 'WPEWebKit': > > This is not correctly indented, no? Indeed. Strange that the local version is correct. I'll update the patch. Created attachment 403469 [details]
Patch
Committed r263933: <https://trac.webkit.org/changeset/263933> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403469 [details]. |