| Summary: | Remove WKkIsTranslated once our bots are updated to the needed SDK | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||
| Component: | Web Template Framework | Assignee: | Saam Barati <saam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, ews-watchlist, mitz, thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | Other | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Saam Barati
2020-06-22 15:23:02 PDT
Rather than using _COMM_PAGE_CPU_CAPABILITIES64, you should consider using the oah_is_current_process_translated SPI. (In reply to mitz from comment #1) > Rather than using _COMM_PAGE_CPU_CAPABILITIES64, you should consider using > the oah_is_current_process_translated SPI. Will do (In reply to Saam Barati from comment #2) > (In reply to mitz from comment #1) > > Rather than using _COMM_PAGE_CPU_CAPABILITIES64, you should consider using > > the oah_is_current_process_translated SPI. > > Will do Better yet, use the public sysctl interface documented at <https://developer.apple.com/documentation/apple_silicon/about_the_rosetta_translation_environment>. (In reply to mitz from comment #3) > (In reply to Saam Barati from comment #2) > > (In reply to mitz from comment #1) > > > Rather than using _COMM_PAGE_CPU_CAPABILITIES64, you should consider using > > > the oah_is_current_process_translated SPI. > > > > Will do > > Better yet, use the public sysctl interface documented at > <https://developer.apple.com/documentation/apple_silicon/ > about_the_rosetta_translation_environment>. 👍🏼 I think we can just make this change now if we're using the sysctl Created attachment 402571 [details]
patch
Comment on attachment 402571 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=402571&action=review > Source/WTF/wtf/TranslatedProcess.cpp:33 > +#include <wtf/DataLog.h> will remove Comment on attachment 402571 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=402571&action=review > Source/WTF/wtf/TranslatedProcess.cpp:33 > +#include <wtf/DataLog.h> Why's this? (In reply to Tim Horton from comment #8) > Comment on attachment 402571 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=402571&action=review > > > Source/WTF/wtf/TranslatedProcess.cpp:33 > > +#include <wtf/DataLog.h> > > Why's this? It was testing. Will remove Created attachment 402572 [details]
patch for landing
Committed r263415: <https://trac.webkit.org/changeset/263415> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402572 [details]. |